[GEN][ZH] Remove unnecessary NULL pointer tests in InGameUI #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Minor
xezon
force-pushed
the
xezon/staticanalysis2/007
branch
from
0584122 to
e4b5340
Compare
Mauller
reviewed
Jun 21, 2025
|
|
||
| // delete the animation instance | ||
| deleteInstance(wad->m_anim); | ||
| WorldAnimationData *wad = *it; |
There was a problem hiding this comment.
i would change these up for while loops since the iterators are being erased and updated within the loop body.
There was a problem hiding this comment.
I will leave it as is too keep the change difference small.
Mauller
reviewed
Jun 21, 2025
| if( mData1 == TRUE ) | ||
| *(Bool *)mData2 = FALSE; | ||
| break; |
There was a problem hiding this comment.
Snuck into this PR but should be okay. i wonder if this fixes anything user focused.
There was a problem hiding this comment.
Oh. That was not meant to be here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes unnecessary NULL pointer tests in InGameUI and makes the compiler happy.
Unnecessary because
m_worldAnimationListwill not accept adding null elements and will not write null to its elements.